Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
|
|
1 similar comment
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding an
epoch-secondstimestamp from JSON or aDocumentcalledTimestamp.applywithout a range check, so out of range values threwIllegalArgumentExceptioninstead ofPayloadError(a 500 instead of a 400 on a server), and values beyond theLongrange wrapped around silently (18446744073709551621decoded to1970-01-01T00:00:05Z). The JSON key decoder also truncated toward zero, so negative fractional keys such as"-1.5", which the encoder produces, could not be decoded.This adds a
private[smithy4s]helper,Timestamp.fromEpochSecondsDecimal, that rounds down, checks the range on theBigDecimalbefore converting toLong, and returns anOption. The JSON value and key decoders and the Document decoder use it and raise a decode error onNone, the same way #2010 handled the other time primitives.PR Checklist (not all items are relevant to all PRs)
Fixes #2021