Repository navigation
Conversation
Each shape's schema was an un-memoized Eval chain, so every reference to a shape re-ran the whole computation of its target. In models where shapes are referenced from several places, this made loading exponential in the depth of the sharing. Schemas are now computed once per shape and shared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2025 to
series/0.18.DynamicSchemaIndex.loaddidn't memoize theEval[Schema]of each shape, so every reference to a shape re-ran the whole computation of its target. In models where shapes are referenced from multiple places this is exponential in the depth of the sharing. The fix.memoizes the schema stored for each shape. See #2025 for the full write-up and numbers (measured on 0.19, where the compiler code is the same): on a large production model with ~25k schemas,loadwent from ~7.2s to ~0.45s.Differences from #2025:
SchemaSharingSpecmatchesSchema.OptionSchema(underlying), sinceOptionSchemahas a single field on 0.18.🤖 Generated with Claude Code