Skip to content

Conversation

@rnazali
Copy link
Contributor

@rnazali rnazali commented Dec 16, 2025

Description

Based on how the discussion in the issue unfolds, I decided to propose a trivial change to remove single line of comment inside DebugToolbarMiddleware.__call__.

I've also added a space on the branching between __acall__ and get_show_toolbar call.

Fixes #2281

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

(I don't think this change need tests nor an extra item in the Pending listing)

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  debug_toolbar
  middleware.py
Project Total  

This report was generated by python-coverage-comment-action

@matthiask matthiask merged commit ac02a69 into django-commons:main Dec 16, 2025
28 checks passed
@matthiask
Copy link
Member

Thank you!

@rnazali rnazali deleted the patch-1 branch December 16, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Superfluous comment inside DebugToolbarMiddleware.__call__

2 participants