Conversation
Signed-off-by: yinyongjun <yintwohao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7326
docker login docker.iostores Docker Hub credentials underhttps://index.docker.io/v1/Previously,
docker logout docker.iotreateddocker.ioas a custom registry and attempted to remove credentials using the literal hostname. As a result, the credentials stored for Docker Hub could remain in the credential store.This change maps
docker.iotohttps://index.docker.io/v1/, makingdocker logout docker.iobehave consistentlywith
docker logout docker.io.However, this change prevents credentials stored under the
docker.iokey in an existingconfig.jsonfrom being removed by this command. However, credentials are written under this key only when logging in withdocker login https://docker.io, so the impact should be minimal.