Skip to content

test(a2a): apply invocation context deltas in fake - #4049

Open
Sayt-0 wants to merge 1 commit into
mainfrom
fix/4048-with-ic-delta-fake
Open

test(a2a): apply invocation context deltas in fake#4049
Sayt-0 wants to merge 1 commit into
mainfrom
fix/4048-with-ic-delta-fake

Conversation

@Sayt-0

@Sayt-0 Sayt-0 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

Fix the A2A invocation-context fake so WithICDelta applies the supplied delta instead of silently discarding it.

Issue expectations

Expectation Implementation
Apply the delta consistently with WithContext, or fail loudly WithICDelta returns a shallow copy and applies Context, UserContent, Agent, Branch, and IsolationScope
Preserve unaffected context state Partial deltas retain all unspecified fields, and the source context is not mutated
Add regression coverage TestFakeInvocationContext_WithICDelta covers complete, nil, partial, and explicit nil-content deltas
Verify the regression Restoring the previous return c implementation makes the new test fail

Validation

  • task build
  • task test
  • task lint
  • go test -race ./pkg/a2a -count=1
  • go vet ./pkg/a2a

Closes #4048

@Sayt-0
Sayt-0 requested a review from a team as a code owner August 24, 2026 13:14
@aheritier aheritier added area/testing Test infrastructure, CI/CD, test runners, evaluation kind/fix PR fixes a bug (maps to fix:). Use on PRs only. labels Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Test infrastructure, CI/CD, test runners, evaluation kind/fix PR fixes a bug (maps to fix:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: fix WithICDelta fake dropping supplied delta

2 participants