Improve secret handling by logging missing secrets and deduplicating … #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgprs
requested changes
Aug 18, 2025
Contributor
kgprs
left a comment
kgprs
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few small changes
Comment on lines
+417
to
+418
| for name := range uniqueSecretNames { | ||
| secretNames = append(secretNames, name) |
Contributor
There was a problem hiding this comment.
I think this can be just secretNames := maps.Keys(uniqueSecretNames)
Author
There was a problem hiding this comment.
Thank you for the comments. It has been updated.
Contributor
There was a problem hiding this comment.
Awesome, I think you missed this comment where we can replace the for-loop though secretNames := maps.Keys(uniqueSecretNames) or maybe forgot to push it
kgprs
added
good first issue
kgprs
requested changes
Aug 18, 2025
Comment on lines
+417
to
+418
| for name := range uniqueSecretNames { | ||
| secretNames = append(secretNames, name) |
Contributor
There was a problem hiding this comment.
Awesome, I think you missed this comment where we can replace the for-loop though secretNames := maps.Keys(uniqueSecretNames) or maybe forgot to push it
slimslenderslacks
approved these changes
Aug 23, 2025
Collaborator
slimslenderslacks
left a comment
slimslenderslacks
left a comment
There was a problem hiding this comment.
Let's merge this
masegraye
pushed a commit
to masegraye/docker-mcp-gateway
that referenced
this pull request
Aug 23, 2025
docker#95) * Improve secret handling by logging missing secrets and deduplicating secret names * Refactor secret deduplication to use struct for improved memory efficiency
null-runner
pushed a commit
to null-runner/mcp-gateway
that referenced
this pull request
Dec 6, 2025
docker#95) * Improve secret handling by logging missing secrets and deduplicating secret names * Refactor secret deduplication to use struct for improved memory efficiency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…secret names
What I did
Related issue
closes #91 #86
(not mandatory) A picture of a cute animal, if possible in relation to what you did