Skip to content

ci: pin starknet-foundry to 0.55.0 to unblock test workflow#3403

Merged
kariy merged 1 commit intomainfrom
ci/pin-snforge
Apr 20, 2026
Merged

ci: pin starknet-foundry to 0.55.0 to unblock test workflow#3403
kariy merged 1 commit intomainfrom
ci/pin-snforge

Conversation

@kariy
Copy link
Copy Markdown
Member

@kariy kariy commented Apr 20, 2026

Summary

CI has been red since foundry-rs/setup-snfoundry@v3 started pulling snforge 0.59.0. That version has an ABI break in starknet::testing::cheatcode against the snforge_std = "0.51" pinned in our Cairo packages, so every run of dojo-core-test and dojo-examples-test panics:

Reading from buffer failed... Probably snforge_std/sncast_std version
is incompatible, check above for incompatibility warning.

snforge itself logs the warning right before the panic:

[WARNING] Package snforge_std version does not meet the recommended version requirement ^0.59.0

Fix

Pin starknet-foundry-version: "0.55.0" on both setup-snfoundry@v3 steps in .github/workflows/test.yml. 0.55.0 is the version that ran on main the last time this workflow was green (2026-01-27, run 21407350594).

Follow-up

The proper long-term fix is bumping snforge_std = "0.51""0.59" (or current) across the three Scarb.toml files:

  • crates/dojo/core-tests/Scarb.toml
  • crates/dojo/dojo-snf-test/Scarb.toml
  • examples/spawn-and-move/Scarb.toml

…and catching up any cheatcode API changes in the tests. That's left for a separate PR so this one can unblock current work.

Test plan

  • dojo-core-test passes on this PR
  • dojo-examples-test passes on this PR

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated testing infrastructure configuration to ensure consistent test environments across builds.

setup-snfoundry@v3 without a version input pulls the latest snforge
(currently 0.59.0), which has an ABI break for starknet::testing::cheatcode
against snforge_std "0.51" pinned in the Cairo packages. This causes every
dojo-core-test and dojo-examples-test run to fail with:

  Reading from buffer failed, ... Probably snforge_std/sncast_std version
  is incompatible, check above for incompatibility warning.

Pin the CLI to 0.55.0 — the version used when main last ran green on
2026-01-27 — to restore CI while the Cairo packages are bumped to 0.59
in a follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026

Ohayo, sensei! 👋

Walkthrough

Added an explicit starknet-foundry-version: "0.55.0" pinning to the Snfoundry setup action across both test jobs in the GitHub Actions workflow. No changes to job logic, step ordering, or execution commands.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/test.yml
Specified starknet-foundry-version: "0.55.0" input for the foundry-rs/setup-snfoundry@v3 action in both dojo-core-test and dojo-examples-test jobs to enforce a consistent Snfoundry version across test runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: pinning starknet-foundry to version 0.55.0 to fix CI test workflow failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/pin-snforge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)

7-24: ⚠️ Potential issue | 🟠 Major

Ohayo sensei — include this workflow file in the path filters.

push and pull_request currently skip this workflow when only .github/workflows/test.yml changes, preventing validation of the dojo-core-test and dojo-examples-test fixes. The path filter check confirms 0 occurrences of - ".github/workflows/test.yml" in the paths lists.

🐛 Proposed fix
   push:
     branches:
       - main
     paths:
+      - ".github/workflows/test.yml"
       - "crates/**"
       - "examples/**"
       - "bin/**"
       - "bindings/**"
@@
   pull_request:
     paths:
+      - ".github/workflows/test.yml"
       - "crates/**"
       - "examples/**"
       - "bin/**"
       - "bindings/**"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/test.yml around lines 7 - 24, The workflow's path filters
for the push and pull_request triggers omit the workflow file itself so changes
to .github/workflows/test.yml won't run the workflow; update both the push and
pull_request paths lists in the test.yml to include an entry for
".github/workflows/test.yml" (add the string "- \".github/workflows/test.yml\""
under the existing paths blocks for push and pull_request) so edits to the
workflow file trigger the workflow runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/test.yml:
- Around line 7-24: The workflow's path filters for the push and pull_request
triggers omit the workflow file itself so changes to .github/workflows/test.yml
won't run the workflow; update both the push and pull_request paths lists in the
test.yml to include an entry for ".github/workflows/test.yml" (add the string "-
\".github/workflows/test.yml\"" under the existing paths blocks for push and
pull_request) so edits to the workflow file trigger the workflow runs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95a39cf4-2220-4077-80c4-843dedb55d0c

📥 Commits

Reviewing files that changed from the base of the PR and between 4a374ac and cdfa8af.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

@kariy kariy merged commit 0712777 into main Apr 20, 2026
2 checks passed
@kariy kariy deleted the ci/pin-snforge branch April 20, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant