ci: pin starknet-foundry to 0.55.0 to unblock test workflow#3403
Conversation
setup-snfoundry@v3 without a version input pulls the latest snforge (currently 0.59.0), which has an ABI break for starknet::testing::cheatcode against snforge_std "0.51" pinned in the Cairo packages. This causes every dojo-core-test and dojo-examples-test run to fail with: Reading from buffer failed, ... Probably snforge_std/sncast_std version is incompatible, check above for incompatibility warning. Pin the CLI to 0.55.0 — the version used when main last ran green on 2026-01-27 — to restore CI while the Cairo packages are bumped to 0.59 in a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Ohayo, sensei! 👋 WalkthroughAdded an explicit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)
7-24:⚠️ Potential issue | 🟠 MajorOhayo sensei — include this workflow file in the path filters.
pushandpull_requestcurrently skip this workflow when only.github/workflows/test.ymlchanges, preventing validation of thedojo-core-testanddojo-examples-testfixes. The path filter check confirms 0 occurrences of- ".github/workflows/test.yml"in the paths lists.🐛 Proposed fix
push: branches: - main paths: + - ".github/workflows/test.yml" - "crates/**" - "examples/**" - "bin/**" - "bindings/**" @@ pull_request: paths: + - ".github/workflows/test.yml" - "crates/**" - "examples/**" - "bin/**" - "bindings/**"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/test.yml around lines 7 - 24, The workflow's path filters for the push and pull_request triggers omit the workflow file itself so changes to .github/workflows/test.yml won't run the workflow; update both the push and pull_request paths lists in the test.yml to include an entry for ".github/workflows/test.yml" (add the string "- \".github/workflows/test.yml\"" under the existing paths blocks for push and pull_request) so edits to the workflow file trigger the workflow runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/test.yml:
- Around line 7-24: The workflow's path filters for the push and pull_request
triggers omit the workflow file itself so changes to .github/workflows/test.yml
won't run the workflow; update both the push and pull_request paths lists in the
test.yml to include an entry for ".github/workflows/test.yml" (add the string "-
\".github/workflows/test.yml\"" under the existing paths blocks for push and
pull_request) so edits to the workflow file trigger the workflow runs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 95a39cf4-2220-4077-80c4-843dedb55d0c
📒 Files selected for processing (1)
.github/workflows/test.yml
Summary
CI has been red since
foundry-rs/setup-snfoundry@v3started pulling snforge 0.59.0. That version has an ABI break instarknet::testing::cheatcodeagainst thesnforge_std = "0.51"pinned in our Cairo packages, so every run ofdojo-core-testanddojo-examples-testpanics:snforge itself logs the warning right before the panic:
Fix
Pin
starknet-foundry-version: "0.55.0"on bothsetup-snfoundry@v3steps in.github/workflows/test.yml. 0.55.0 is the version that ran on main the last time this workflow was green (2026-01-27, run21407350594).Follow-up
The proper long-term fix is bumping
snforge_std = "0.51"→"0.59"(or current) across the threeScarb.tomlfiles:crates/dojo/core-tests/Scarb.tomlcrates/dojo/dojo-snf-test/Scarb.tomlexamples/spawn-and-move/Scarb.toml…and catching up any cheatcode API changes in the tests. That's left for a separate PR so this one can unblock current work.
Test plan
dojo-core-testpasses on this PRdojo-examples-testpasses on this PR🤖 Generated with Claude Code
Summary by CodeRabbit