Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmcpERTQ1WaRZ73F12eUis
frioux
added a commit
to frioux/FFCC-Decomp
that referenced
this pull request
Nov 10, 2026
GC/2.5a is now doldecomp/mweppc's GC_2_5a (GC 2.5 built from the decompiled source with the kss rule, doldecomp/mweppc#3) rather than a byte patch of the bundled GC/2.5. tools/download_mweppc.py installs it from mweppc's release archive, pinned by URL and SHA-256; until that release exists RELEASE is None and the build stops with a message naming the pending value. tools/patch_compiler_pal.py and its ninja rule are removed. Validated with a locally built GC_2_5a: objects byte-identical to the byte-patched GC/2.5a; report.json unchanged in all three regions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmcpERTQ1WaRZ73F12eUis
This was referenced Nov 10, 2026
Author
|
Closing in favour of PrimeDecomp/mwcc-tools#3, the same change ported to mwcc-tools' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GC_2_5a, a derived version likeGC_2_0p2: GameCube 2.5 plus one alias-analysis rule that the PAL and USA game code of the Final Fantasy Crystal Chronicles decompilation needs. The name "2.5a" is provisional; happy to rename it (2.5p1, 2.5f, ...) if you prefer.What
include/version.h:VERSION_GC_2_5Abetween 2.5 and 2.6 (2.6 and 2.7 move up one index),config/GC_2_5a/config.jsonwith"derived_from": "GC_2_5".VERSION == VERSION_GC_2_5tests now include 2.5a (#elif VERSION <= VERSION_GC_2_5Ain the chains that already start with< VERSION_GC_2_5, the same way<= VERSION_GC_2_0P2is used;== VERSION_GC_2_5 || == VERSION_GC_2_5Afor the standalone ones), so 2.5a is 2.5 everywhere else, build 105 included.Alias.coperand_alias, 2.5a only: a store through a base register with several reaching definitions, some with an alias and some without, keeps the alias of those that have one when it is a single static object (Object/ObjectPartwhose object is notDLOCAL), instead of becomingworst_case. Loads, and stores into locals, are unchanged.Why / evidence
All measured on FFCC's game code, every unit the project builds with GC/2.5, scored per function like FFCC's
report.json(objdiff 3.6.1).pppRand*vector randomizers store each channel throughtarget = (off == -1) ? (T*)gPppDefaultValueBuffer : (T*)(work + off)while reading*valuePtr. Retail loads*valuePtronce; 2.5 reloads it after every store throughtarget(it isworst_case). FFCC's current source works around that with ascalelocal, which leaves nine functions at 87-97%.pppRand*pppRand*targetloads move above the stores); for every store, including into locals, losesCMenuPcs::loadData(a store into a local array). Static objects only (this PR) loses nothing.pppRandIV, per-channel source):Only FFCC has been measured; I had no other GameCube 2.5 project at hand. Nothing changes for anyone who does not select 2.5a.
How tested (macOS arm64, LLVM 23)
python configure.py && ninja: all six versions build with clang.build/GC_{2_0,2_0p2,2_5,2_6,2_7}/clang/mwcceppc.exeare byte-identical to the same build ofmain.configure.py --mwcc:ninja build/GC_2_0/ok build/GC_2_5/ok build/GC_2_6/ok build/GC_2_7/okgives the same per-function results asmain(compare.jsonidentical apart from object hashes), andbuild/GC_2_5a/source-only/mwcceppc.exeandbuild/GC_2_0p2/source-only/mwcceppc.exelink ("4079 functions, all from the sources"). On this host the exact counts are two lower than the README's for every version, onmainas well.ruff format --check,ruff check,clang-format --dry-run -Werroron all C sources: clean.--matching/relink.ok,tools/verify.py's full regressions baseline, and the native Linux build (not available on arm64 macOS). Downloading the original compilers from files.decomp.dev failed here with an SSL error, so I seededbuild/compilersfrom FFCC's copy of the samecompilers_20250812bundle.FFCC will switch from its current byte-patched 2.5 (PR zcanann/FFCC-Decomp#17827) to this build once it is merged and released; the FFCC side expects the release archive to carry
2.5a/mwcceppc.exenext to2.5/.🤖 Generated with Claude Code
https://claude.ai/code/session_01QmcpERTQ1WaRZ73F12eUis