Skip to content

fix(BWanwan): naming + using proper enums + more matching - #404

Merged
Mrkol merged 4 commits into
doldecomp:mainfrom
MagiHotline:bw-fixes
Nov 16, 2026
Merged

Mrkol merged 4 commits into
doldecomp:mainfrom
MagiHotline:bw-fixes

Conversation

@MagiHotline

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Report for GMSJ01 (d131ac2 - c5df48c)

📈 9 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/bosswanwan TNerveBWGraphWander::execute(TSpineBase<TLiveActor>*) const +85 95.64% 98.96%
mario/Enemy/bosswanwan TBWLeashNode::perform(unsigned long, JDrama::TGraphics*) +49 91.04% 99.84%
mario/Enemy/bosswanwan TBWLeash::TBWLeash(TBossWanwan*, int, const char*) +35 95.62% 99.81%
mario/Enemy/bosswanwan TBossWanwan::init(TLiveManager*) +28 95.11% 96.55%
mario/Enemy/bosswanwan TBWBinder::bind(TLiveActor*) +15 97.31% 97.91%
mario/Enemy/bosswanwan TNerveBWDie::execute(TSpineBase<TLiveActor>*) const +10 98.32% 99.17%
mario/Enemy/bosswanwan TNerveBWStun::execute(TSpineBase<TLiveActor>*) const +5 99.04% 99.62%
mario/Enemy/bosswanwan TBossWanwan::perform(unsigned long, JDrama::TGraphics*) +2 97.10% 97.21%
mario/Enemy/bosswanwan TBossWanwan::shakeCamera(int) +1 99.57% 99.77%

Report for GMSJ01_01 (d131ac2 - c5df48c)

📈 9 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/bosswanwan TNerveBWGraphWander::execute(TSpineBase<TLiveActor>*) const +85 95.64% 98.96%
mario/Enemy/bosswanwan TBWLeashNode::perform(unsigned long, JDrama::TGraphics*) +49 91.04% 99.84%
mario/Enemy/bosswanwan TBWLeash::TBWLeash(TBossWanwan*, int, const char*) +35 95.62% 99.81%
mario/Enemy/bosswanwan TBossWanwan::init(TLiveManager*) +28 95.11% 96.55%
mario/Enemy/bosswanwan TBWBinder::bind(TLiveActor*) +15 97.31% 97.91%
mario/Enemy/bosswanwan TNerveBWDie::execute(TSpineBase<TLiveActor>*) const +10 98.32% 99.17%
mario/Enemy/bosswanwan TNerveBWStun::execute(TSpineBase<TLiveActor>*) const +5 99.04% 99.62%
mario/Enemy/bosswanwan TBossWanwan::perform(unsigned long, JDrama::TGraphics*) +2 97.10% 97.21%
mario/Enemy/bosswanwan TBossWanwan::shakeCamera(int) +1 99.57% 99.77%

Report for GMSE01 (d131ac2 - c5df48c)

📈 9 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/bosswanwan TNerveBWGraphWander::execute(TSpineBase<TLiveActor>*) const +85 95.38% 98.70%
mario/Enemy/bosswanwan TBWLeashNode::perform(unsigned long, JDrama::TGraphics*) +49 91.04% 99.84%
mario/Enemy/bosswanwan TBWLeash::TBWLeash(TBossWanwan*, int, const char*) +35 95.62% 99.81%
mario/Enemy/bosswanwan TBossWanwan::init(TLiveManager*) +28 95.11% 96.55%
mario/Enemy/bosswanwan TBWBinder::bind(TLiveActor*) +15 97.31% 97.91%
mario/Enemy/bosswanwan TNerveBWDie::execute(TSpineBase<TLiveActor>*) const +10 98.32% 99.17%
mario/Enemy/bosswanwan TNerveBWStun::execute(TSpineBase<TLiveActor>*) const +5 99.04% 99.62%
mario/Enemy/bosswanwan TBossWanwan::perform(unsigned long, JDrama::TGraphics*) +2 96.11% 96.22%
mario/Enemy/bosswanwan TBossWanwan::shakeCamera(int) +1 99.57% 99.77%

Report for GMSP01_NX (d131ac2 - c5df48c)

📈 9 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/bosswanwan TNerveBWGraphWander::execute(TSpineBase<TLiveActor>*) const +85 95.38% 98.70%
mario/Enemy/bosswanwan TBWLeashNode::perform(unsigned long, JDrama::TGraphics*) +49 91.04% 99.84%
mario/Enemy/bosswanwan TBWLeash::TBWLeash(TBossWanwan*, int, const char*) +35 95.62% 99.81%
mario/Enemy/bosswanwan TBossWanwan::init(TLiveManager*) +28 95.11% 96.55%
mario/Enemy/bosswanwan TBWBinder::bind(TLiveActor*) +15 97.31% 97.91%
mario/Enemy/bosswanwan TNerveBWDie::execute(TSpineBase<TLiveActor>*) const +10 98.32% 99.17%
mario/Enemy/bosswanwan TNerveBWStun::execute(TSpineBase<TLiveActor>*) const +5 99.04% 99.62%
mario/Enemy/bosswanwan TBossWanwan::perform(unsigned long, JDrama::TGraphics*) +2 96.11% 96.22%
mario/Enemy/bosswanwan TBossWanwan::shakeCamera(int) +1 99.57% 99.77%

Report for GMSP01 (d131ac2 - c5df48c)

📈 9 improvements in unmatched items
Unit Item Bytes Before After
mario/Enemy/bosswanwan TNerveBWGraphWander::execute(TSpineBase<TLiveActor>*) const +85 95.38% 98.70%
mario/Enemy/bosswanwan TBWLeashNode::perform(unsigned long, JDrama::TGraphics*) +49 91.04% 99.84%
mario/Enemy/bosswanwan TBWLeash::TBWLeash(TBossWanwan*, int, const char*) +35 95.62% 99.81%
mario/Enemy/bosswanwan TBossWanwan::init(TLiveManager*) +28 95.11% 96.55%
mario/Enemy/bosswanwan TBWBinder::bind(TLiveActor*) +15 97.31% 97.91%
mario/Enemy/bosswanwan TNerveBWDie::execute(TSpineBase<TLiveActor>*) const +10 98.32% 99.17%
mario/Enemy/bosswanwan TNerveBWStun::execute(TSpineBase<TLiveActor>*) const +5 99.04% 99.62%
mario/Enemy/bosswanwan TBossWanwan::perform(unsigned long, JDrama::TGraphics*) +2 96.11% 96.22%
mario/Enemy/bosswanwan TBossWanwan::shakeCamera(int) +1 99.57% 99.77%

Comment thread src/Enemy/bosswanwan.cpp Resolved
Comment thread src/Enemy/bosswanwan.cpp Resolved
@Mrkol

Mrkol commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

massive regression in TBWBinder btw

@MagiHotline

Copy link
Copy Markdown
Contributor Author

Still investigating it. TBWBinder::bind it's pita. I think it's mostly because I changed from my fabricated func to fromPolar :/

@MagiHotline

Copy link
Copy Markdown
Contributor Author

General improvements

mario/Enemy/bosswanwan | fuzzy_match   |  97.96% ->  98.47%
perform__12TBWLeashNodeFUlPQ26JDrama9TGraphics | fuzzy_match   |  91.04% ->  99.84%
__ct__8TBWLeashFP11TBossWanwaniPCc | fuzzy_match   |  95.62% ->  99.81%
init__11TBossWanwanFP12TLiveManager | fuzzy_match   |  95.11% ->  96.55%
shakeCamera__11TBossWanwanFi | fuzzy_match   |  99.57% ->  99.77%
perform__11TBossWanwanFUlPQ26JDrama9TGraphics | fuzzy_match   |  97.10% ->  97.21%
execute__19TNerveBWGraphWanderCFP24TSpineBase<10TLiveActor> | fuzzy_match   |  95.64% ->  97.56%
execute__12TNerveBWJumpCFP24TSpineBase<10TLiveActor> | fuzzy_match   |  96.55% ->  97.80%
execute__12TNerveBWStunCFP24TSpineBase<10TLiveActor> | fuzzy_match   |  99.04% ->  99.62%
execute__18TNerveBWJumpToBathCFP24TSpineBase<10TLiveActor> | fuzzy_match   |  97.58% ->  97.61%
execute__11TNerveBWDieCFP24TSpineBase<10TLiveActor> | fuzzy_match   |  98.32% ->  99.17%

@Mrkol
Mrkol merged commit 4b5027a into doldecomp:main Nov 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants