Repository navigation
better Kukku - #405
better Kukku#405
Conversation
Report for GMSJ01 (fe440d5 - f7c2545)📈 Matched code: 52.84% (+0.02%, +748 bytes) ✅ 2 new matches
📈 5 improvements in unmatched items
Report for GMSP01 (fe440d5 - f7c2545)📈 Matched code: 52.36% (+0.02%, +748 bytes) ✅ 2 new matches
📈 5 improvements in unmatched items
Report for GMSP01_NX (fe440d5 - f7c2545)📈 Matched code: 52.10% (+0.02%, +748 bytes) ✅ 2 new matches
📈 5 improvements in unmatched items
Report for GMSE01 (fe440d5 - f7c2545)📈 Matched code: 51.77% (+0.02%, +748 bytes) ✅ 2 new matches
📈 5 improvements in unmatched items
Report for GMSJ01_01 (fe440d5 - f7c2545)📈 Matched code: 52.03% (+0.02%, +748 bytes) ✅ 2 new matches
📈 5 improvements in unmatched items
|
| mSpine->reset(); | ||
| mSpine->setNext(&TNerveKukkuFall::theNerve()); | ||
| if (!isFalling()) { | ||
| if (!isRecoveringGraph()) { |
There was a problem hiding this comment.
Hm? Why 2 ifs, codegen should be identical to && (as long as you do the !)
There was a problem hiding this comment.
u right, it has same codegen
| void TKukku::updateRotation() | ||
| { | ||
| JGeometry::TVec3<f32> toTarget = mCurrentTarget.getPoint(); | ||
| JGeometry::TVec3<f32> toTarget = getCurrentTarget().getPoint(); |
There was a problem hiding this comment.
fakematch for stack padding or does it actually change codegen?
There was a problem hiding this comment.
it actually changes codegen adding this getter
| // kukku->doFlyToCurPathNode(); | ||
| // Biggest what if? fly calls update and then calls recover, so that it can | ||
| // call callmomentum and being inlined regularly. understanding if | ||
| // updateRotation needs to be called there or somewhere else. |
There was a problem hiding this comment.
I don't get what you're trying to say here 😅
There was a problem hiding this comment.
TNerveKukkuGraphWander seems to calling the unused function doFlyToCurPathNode() (which seems to match in TNerveKukkuRecoverGraph) but it emits out of line updateRotation(). It for sure is a problem on how I decided the body of these unused functions :/ but in one it seems to have worked so that's why I understand this bit
Slight improvements, still figuring out stuff