Upgrade to V4 Arcade publishing#565
Open
mmitche wants to merge 4 commits into
Open
Conversation
mmitche
force-pushed
the
dev/mmitche/arcade-v4-publishing
branch
from
July 15, 2026 16:45
2b185e7 to
57d3973
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mmitche
force-pushed
the
dev/mmitche/arcade-v4-publishing
branch
from
July 15, 2026 17:21
57d3973 to
87af2c9
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cdd830ac-44ac-4fe8-96e7-44dfffb28763
mmitche
commented
Jul 17, 2026
| displayName: Setup Private Feeds Credentials | ||
| condition: eq(variables['Agent.OS'], 'Windows_NT') | ||
| inputs: | ||
| filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1 |
Member
Author
There was a problem hiding this comment.
Replace this with the enable-internal-sources yml template.
mmitche
commented
Jul 17, 2026
| displayName: 'Push NetCore.Launcher NuPkgs to DevDiv VS feed' | ||
| condition: succeeded() | ||
| - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: | ||
| - powershell: | |
Member
Author
There was a problem hiding this comment.
I still think this is incorrect. This seems to imply that publishing is not beign used properly in the repository. When publishing is enabled and items are in the publishing itemgroups, then they will get copied to the staging directories. I think all of these steps should be eliminated.
…s automatically Arcade's job.yml template with publishingVersion:4 + enablePublishing runs Publish.proj, which locally stages shipping/nonshipping packages, asset manifests, and PDBs to $(Build.ArtifactStagingDirectory)/artifacts and publishes them as $(System.PhaseName)_Artifacts. The manual staging steps and the IntermediateUnsignedArtifacts/PdbArtifacts outputs duplicated this and are removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cdd830ac-44ac-4fe8-96e7-44dfffb28763
Replace the manual SetupNugetSources.ps1 + PAT step with the standard enable-internal-sources.yml template, which uses federated auth (dnceng-artifacts-feeds-read) and handles NuGetAuthenticate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cdd830ac-44ac-4fe8-96e7-44dfffb28763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishingVersionto 4 and wire official publish-build-assets/post-build templates for V4./eng/common/templates-official/job/job.yml@selfso Arcade's wrapper emits the V4$(System.PhaseName)_Artifactsoutput.$(Build.ArtifactStagingDirectory)/artifactsbecause this repo's build writes them under repoartifacts/rather than directly into the wrapper staging directory.System.Security.Cryptography.Xmlto 8.0.4 to unblock current official NuGet audit errors.Validation tracking