Skip to content

Suggest unopened active-pattern cases in patterns - #20719

Draft
T-Gro wants to merge 5 commits into
mainfrom
t-gro-active-pattern-implementation
Draft

Suggest unopened active-pattern cases in patterns#20719
T-Gro wants to merge 5 commits into
mainfrom
t-gro-active-pattern-implementation

Conversation

@T-Gro

@T-Gro T-Gro commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Completion offers individual active-pattern cases from unopened modules, with usable names and import metadata. Bare variable bindings retain their existing meaning.

No linked issue.

Local full FCS Release suites pass in classic and transparent modes. Final-head CI remains pending.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

T-Gro and others added 2 commits October 6, 2026 18:03
@T-Gro
Stabilize active-pattern tooling and measured catalogue cache
4af6b2b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-Gro
Separate AP tooling from the independent catalogue cache
0165648 
Preserve the complete source snapshot for the cache owner, remove only the cache slice, reuse editor test helpers, and prepare release notes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Release notes checked

✅ Found changes and release notes in following paths:

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.200.md

T-Gro and others added 3 commits October 6, 2026 18:44
@T-Gro
Link active-pattern tooling release notes to the draft PR
4308368 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-Gro
Fix desktop edit-test APIs and compact verified assertion recipes
0d1d39d 
Preserve all completion and editor scenarios while using the net472-compatible Replace overload and existing edited-source assertions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-Gro
Separate the dependent editor layer from FCS case completion
104e495 
Preserve the tested complete source and exact editor export while retaining the FCS completion/catalogue changes and release note in this lower draft.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Status: New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@T-Gro