Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Gro
added this pull request to stack #20724
October 7, 2026 07:37
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggest active-pattern imports in pattern positions and apply completion edits with the correct qualification and open placement. Do not offer unusable or duplicate imports.
Depends on #20719; targets
t-gro-active-pattern-implementation. Azure PR validation now acceptst-gro-*maintainer targets so this dependent layer can run the native editor suite; push triggers and pipeline jobs are unchanged.No closing issue.
Local validation with pinned SDK
11.0.100-rc.1.26420.103andBUILDING_USING_DOTNET=true:dotnet fantomas .— passed, no changes.git diff --check— passed.dotnet test --project tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj -c Release --filter-class '*ActivePatternCompletionTests*' --filter-class '*AssemblyContentProviderTests*' --filter-class '*OpenDeclarationInsertionTests*' --filter-class '*CompletionPatternMatchingTests*' --report-spekt-xunit --results-directory /Users/tomasgrosup/.copilot/session-state/32e5a10e-79d0-45aa-8b49-4251a4bc61af/files/fcs-related-results /bl:/Users/tomasgrosup/.copilot/session-state/32e5a10e-79d0-45aa-8b49-4251a4bc61af/files/fcs-related.binlog— passed: 85 passed, one existing explicit skip, no failures. The same selection also passed withTEST_TRANSPARENT_COMPILER=1: 85 passed, one explicit skip, no failures.dotnet test --project vsintegration/tests/FSharp.Editor.Tests/FSharp.Editor.Tests.fsproj -c Release --filter-class '*ActivePatternEditorTests*' --report-spekt-xunit --results-directory /Users/tomasgrosup/.copilot/session-state/32e5a10e-79d0-45aa-8b49-4251a4bc61af/files/editor-local-results /bl:/Users/tomasgrosup/.copilot/session-state/32e5a10e-79d0-45aa-8b49-4251a4bc61af/files/editor-local.binlog— blocked at restore on macOS by NU1201: Unix test utilities target net11.0, while editor tests require net472. Native Windows execution of all 28 new scenarios and related Add Open/completion tests is pending CI.Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: