New Binding: Ina236 #2459
Open
New Binding: Ina236 #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you please split the PRs by differentiating the tasks? I see changes to the lang versions along with other stuff not related to the binding. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new device binding for the INA236 voltage and current sensor, along with significant improvements to the repository's testing infrastructure and language version standardization.
Key Changes:
- New INA236 device binding with complete implementation including tests, samples, and documentation
- Introduction of I2cSimulatedDeviceBase class to provide a reusable testing infrastructure for I2C devices
- Standardization of C# language version to 12 across the entire repository
- Refactoring of existing Tca955x tests to use the new simulated device infrastructure
Reviewed changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| src/devices/Ina236/Ina236.cs | Main INA236 device implementation with voltage/current/power monitoring capabilities |
| src/devices/Ina236/Ina236OperatingMode.cs | Operating mode enumeration for device configuration |
| src/devices/Ina236/Ina236Register.cs | Register address definitions |
| src/devices/Ina236/README.md | Device documentation and usage examples |
| src/devices/Ina236/samples/Program.cs | Sample code demonstrating device usage |
| src/devices/Ina236/tests/Ina236Tests.cs | Unit tests for INA236 device |
| src/devices/Ina236/tests/SimulatedIna236.cs | Simulated device for testing |
| src/devices/Common/System/Device/I2c/I2cSimulatedDeviceBase.cs | New base class for simulating I2C devices in tests |
| src/devices/Tca955x/tests/Tca955xSimulatedDevice.cs | New simulated device using the base infrastructure |
| src/devices/Tca955x/tests/Tca9554Tests.cs | Refactored tests using new infrastructure |
| src/devices/Tca955x/tests/Tca9555Tests.cs | Refactored tests using new infrastructure |
| Directory.Build.props | Updated default LangVersion to 12 |
| samples/Directory.Build.props | Updated default LangVersion to 12 |
| Multiple .csproj files | Removed explicit LangVersion settings to use default |
| src/devices/Gpio/README.md | Fixed table formatting and typos |
| src/devices/Tca955x/README.md | Fixed spelling errors |
| samples/README.md | Updated .NET version requirements |
| Assert.Equal(PinValue.High, value); | ||
| pin8.Dispose(); | ||
| pin0.Dispose(); | ||
| Assert.False(tcaController.IsPinOpen(8)); |
There was a problem hiding this comment.
The assertion checks if pin 8 is closed after closing pin 0. This appears to be a copy-paste error - it should check if pin 0 is closed instead.
dotnet-policy-service
bot
added
the
area-device-bindings
Ellerbach
reviewed
Jan 28, 2026
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
couple of comments, looks nice!
src/devices/Ina236/Ina236.cs
Outdated
| /// Type B has addresses 0x44 to 0x47, depending on the ADDR pin. | ||
| /// </summary> | ||
| public const int DefaultI2cAddress = 0x40; | ||
| private I2cDevice _i2cDevice; |
Contributor
Author
There was a problem hiding this comment.
Changed it to nullable, so I can throw deterministic ObjectDisposedException's.
Generic implementation is difficult, one problem is the different argument sizes and the fact that the endianess on the bus may change.
Will make it easier in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Binding for INA236 voltage and current sensor. It's similar to the existing binding INA219 in functionality, but the registers are quite different, so that a common base class is not useful. Could think of a common interface, though.
Alarm features are not implemented as the breakouts from most suppliers don't seem to have the ALRT pin wired out.
Microsoft Reviewers: Open in CodeFlow