Temporarily disable It_builds_deps_correctly_when_projects_do_not_get_restored (msbuild#14274 regression) - #55265
Closed
JanProvaznik wants to merge 1 commit into
Closed
Conversation
…_restored Same root cause as ItCanTestAMultiTFMProjectWithImplicitRestore (dotnet#55263): dotnet/msbuild#14274 (ExcludeRestorePackageImports during restore, change wave 18.10) regresses restore for projects excluded from restore via _IsProjectRestoreSupported. For the 'TestApp.' case, TestApp.deps.json lists transitive non-SDK project references by their project name instead of the overridden AssemblyName. Disable pending the msbuild#14349 revert flowing in. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 499249b7-514f-4ecf-88bc-2466455069c5
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily disables a failing Microsoft.NET.Build.Tests test that regressed under the MSBuild change wave 18.10 behavior introduced by dotnet/msbuild#14274 (implicit restore using ExcludeRestorePackageImports=true), tracked for re-enable in #55263 once the MSBuild revert (dotnet/msbuild#14349) flows in.
Changes:
- Marks
It_builds_deps_correctly_when_projects_do_not_get_restoredas ignored with a tracking link to #55263.
Comment on lines
29
to
32
| [DataRow("")] | ||
| [DataRow("TestApp.")] | ||
| [Ignore("https://github.com/dotnet/sdk/issues/55263")] | ||
| public void It_builds_deps_correctly_when_projects_do_not_get_restored(string prefix) |
Member
Author
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily disables
It_builds_deps_correctly_when_projects_do_not_get_restored(Microsoft.NET.Build.Tests), which regresses under the MSBuild flow that includes dotnet/msbuild#14274 (ExcludeRestorePackageImports=trueduring implicit restore, change wave 18.10).This is the same root cause as
ItCanTestAMultiTFMProjectWithImplicitRestore, which was already disabled under #55263. For the[DataRow("TestApp.")]case,TestApp.deps.jsonnow lists transitive non-SDK project references (excluded from restore via_IsProjectRestoreSupported) by their project name instead of their overriddenAssemblyName.Confirmed locally (rebuilding the SDK with MSBuild
18.10.0-1.26360.102): fails with change wave 18.10 enabled, passes withMSBUILDDISABLEFEATURESFROMVERSION=18.10.The MSBuild change is being reverted in dotnet/msbuild#14349. Tracked for re-enable (alongside the other test) in #55263.