Suppress advertising manifest messages unless verbosity is diagnostic#55276
Draft
marcpopMSFT with Copilot wants to merge 6 commits into
Draft
Suppress advertising manifest messages unless verbosity is diagnostic#55276marcpopMSFT with Copilot wants to merge 6 commits into
marcpopMSFT with Copilot wants to merge 6 commits into
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Changed _validationMessagesDisplayed flag from instance-level to static to ensure "Skipping NuGet package signature verification." message appears only once across all NuGetPackageDownloader instances during workload operations, rather than once per instance. Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot created this pull request from a session on behalf of
marcpopMSFT
July 14, 2026 19:01
View session
Member
|
@copilot fix the failed build: I believe it should be TestAssetsManager instead. |
Member
|
Tested in codespace. Confirmed that we don't see the advertising manifest messages anymore in manifest mode unless diag verbosity is used. |
…in ItSuppressesMessagesWhenDisplayManifestUpdatesIsFalse Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the first 5 commits from #51560 (targeting
release/10.0.4xx) ontomain, without the accumulated merge commits.Changes
WorkloadManifestUpdater— adds adisplayManifestUpdatesbool parameter; advertising manifest messages (e.g.AdManifestPackageDoesNotExist) are only emitted whentrueinstall,update,list) — passdisplayManifestUpdatesbased on whether verbosity isdiagnostic; all other verbosity levels suppress these messagesCommonOptionsExtensions— addsIsDiagnostic()extension onVerbosityOptionsNuGetPackageDownloader— makes_validationMessagesDisplayedstaticso "Skipping NuGet package signature verification." appears at most once per process, not once per downloader instanceItSuppressesMessagesWhenDisplayManifestUpdatesIsFalse; updatedHideManifestUpdatesWhenVerbosityIsMinimalOrNormalto include--verbosity:detailed; renamedShowManifestUpdatesWhenVerbosityIsDetailedOrDiagnostic→ShowManifestUpdatesWhenVerbosityIsDiagnosticwith only thediagnosticdata rowConflicts resolved during cherry-pick:
usingdirectives inCommonOptionsExtensions.cs(main had added three additional usings post-branch); xUnit[Fact]/[Theory]/[InlineData]test attributes converted to MSTest equivalents.