Fixed a lot of typos in the codebase and documentation#55327
Open
HotCakeX wants to merge 2 commits into
Open
Conversation
Fixed a lot of typos across the code base and documentations. Changed made to the codes have been carefully reviewed to ensure they only fix typos, nothing else.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
the
sdk-diagnostic-docs-needed
Contributor
📋 SDK Diagnostic Documentation ReminderThis PR introduces 1 new SDK diagnostic code:
Action RequiredPlease ensure that documentation for this diagnostic is added or updated in the dotnet/docs repository at:
Each diagnostic should have:
Thank you for helping keep our documentation up to date! 🙏 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs typo corrections across the .NET SDK repo, spanning tests, MSBuild tasks/targets, developer documentation, and localized resource strings to improve clarity and consistency without intended behavior changes.
Changes:
- Fixes misspellings in identifiers/parameter names in test and source code (e.g.,
identifer→identifier), plus related comments. - Corrects typos in MSBuild tasks/targets and analyzer/test comments.
- Updates docs and resource strings (
.resxand corresponding.xlf) to correct misspellings in user-facing text.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs | Renames local variable identifer → identifier and fixes a nearby comment typo. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs | Fixes named argument and parameter spelling identifer → identifier. |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreApp.cs | Fixes a comment typo (“Identifer” → “Identifier”). |
| src/WebSdk/Publish/Tasks/Tasks/MsDeploy/NormalizeServiceUrl.cs | Fixes comment typo (“explicityly” → “explicitly”). |
| src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs | Fixes comment typos (“fond teh” → “found the”). |
| src/TemplateEngine/Tools/Microsoft.TemplateEngine.TemplateLocalizer.Core/ExportResult.cs | Fixes XML doc typo (“occured” → “occurred”). |
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.WindowsSdkSupportedTargetPlatforms.props | Fixes comment typo (“verison” → “version”). |
| src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageDependencies.cs | Fixes doc comment typo (“compatability” → “compatibility”). |
| src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs | Fixes private method name typo (ShouldWarnOnRuntimeIdentifer → ShouldWarnOnRuntimeIdentifier) and updates usages. |
| src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.tr.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.ru.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.pl.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.ko.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.ja.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.it.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.fr.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.es.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.de.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/xlf/Strings.cs.xlf | Updates localized resource <source> text to fix “identifer” → “identifier”. |
| src/Tasks/Common/Resources/Strings.resx | Fixes user-facing resource text typo (“identifer” → “identifier”). |
| src/RazorSdk/Tool/ShadowCopyManager.cs | Fixes comment typo (“existance” → “existence”). |
| src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs | Fixes comment typo (“containg” → “containing”). |
| src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/Microsoft.NetFramework.Analyzers/Helpers/SecurityDiagnosticHelpers.cs | Fixes comment typo (“verison” → “version”). |
| src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.CSharp.NetAnalyzers/Microsoft.NetCore.Analyzers/InteropServices/CSharpDisableRuntimeMarshalling.Fixer.cs | Fixes local variable name typo (renameIdentiferAnnotation → renameIdentifierAnnotation). |
| src/Microsoft.CodeAnalysis.NetAnalyzers/docs/performance.md | Fixes typo (“mutli-core” → “multi-core”) and removes unintended indentation affecting rendering. |
| src/Dotnet.Watch/Watch/Process/ProcessRunner.cs | Fixes XML doc typo (“Virutal” → “Virtual”). |
| src/Dotnet.Watch/dotnet-watch/README.md | Fixes typo (“successfuly” → “successfully”). |
| src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/Filtering/SymbolFilterFactory.cs | Fixes XML doc typos (“specifed” → “specified”). |
| documentation/TemplateEngine/template-resolution-for-dotnet-cli.md | Fixes typo (“moving o” → “moving to”) and removes unintended indentation affecting rendering. |
| documentation/TemplateEngine/Post-Action-Registry.md | Fixes duplicated word typo (“will be be ignored” → “will be ignored”). |
| documentation/TemplateEngine/contributing/how-to-create-new-generated-symbol.md | Fixes typo (“implemetation” → “implementation”). |
| documentation/TemplateEngine/Conditions.md | Fixes typo (“dependant” → “dependent”). |
| documentation/general/SelfContainedBreakingChangeNotification.md | Fixes typo (“RuntimeIdentifer” → “RuntimeIdentifier”). |
| **Input** - currently only other parameter symbols from the template configuration are supported within the parameter conditions. Any other variables are not bound and replaced (they are considered part of literal string). | ||
|
|
||
| **Evaluation order** - Dependencies between parameters are detected and evaluation is performed in order that guarantees that all dependencies are evaluated prior their dependant (see [Topological Sorting](https://en.wikipedia.org/wiki/Topological_sorting) for details). | ||
| **Evaluation order** - Dependencies between parameters are detected and evaluation is performed in order that guarantees that all dependencies are evaluated prior their dependent (see [Topological Sorting](https://en.wikipedia.org/wiki/Topological_sorting) for details). |
Member
There was a problem hiding this comment.
This one might have been correct?
| </trans-unit> | ||
| <trans-unit id="UnsupportedTargetPlatformIdentifierWithWorkloadsDisabled"> | ||
| <source>NETSDK1208: The target platform identifier {0} was not recognized. This is because MSBuildEnableWorkloadResolver is set to false which disables .NET SDK Workloads which is required for this identifer. Unset this environment variable or MSBuild property to enable workloads.</source> | ||
| <source>NETSDK1208: The target platform identifier {0} was not recognized. This is because MSBuildEnableWorkloadResolver is set to false which disables .NET SDK Workloads which is required for this identifier. Unset this environment variable or MSBuild property to enable workloads.</source> |
Member
There was a problem hiding this comment.
I'd expect these to get re-marked for translation. Assuming this was done via a tool, the right step may be to revert all the changes to the .xlf files and then just do a rebuild to let the tooling update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a lot of typos across the code base and documentations. These are not nitpicking, personal preferences nor grammar errors, these are obvious typos. Changes made to the codes have been carefully reviewed to ensure they only fix typos, nothing else.
Here are some of the examples of fixed typos:
dependant->dependentwill be be ignored->will be ignoredspecifed->specifiedsuccessfuly->successfullyverison->versionidentifer->identifierexistance->existencecontaing->containingmutli-core->multi-coreVirutal->Virtualfond teh item->found the itemAnd so on.