Repository navigation
[Application Builder] Establish the WinForms host and application lifetime - #15240
Closed
JayashreeSF3546 wants to merge 6 commits into
Closed
JayashreeSF3546 wants to merge 6 commits into
JayashreeSF3546 wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15240 +/- ##
=============================================
Coverage 37.84861% 37.84861%
=============================================
Files 246 246
Lines 9789 9789
Branches 1031 1031
=============================================
Hits 3705 3705
Misses 5920 5920
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed changes
Application.Runbehavior while supporting startup forms and customApplicationContextinstances.Acceptance criteria
ApplicationContextscenarios are supported.Application.Runapplications remain supported and source compatible.Definition of Done
Customer Impact
Application.Runusage remains supported.Regression?
Application.Runbehavior is retained.Risk
Screenshots
N/A — no visual UI changes.
Test methodology
dotnet test src\application-builder\..\..\test\unit\System.Windows.Forms\System.Windows.Forms.Tests.csproj --configuration Debug --no-build --no-restore -- --filter-class "System.Windows.Forms.Tests.WinFormsApplicationBuilderTests"— 31 passed, 0 failed.Correction: use the actual test project path:
dotnet test src\test\unit\System.Windows.Forms\System.Windows.Forms.Tests.csproj --configuration Debug --no-build --no-restore -- --filter-class "System.Windows.Forms.Tests.WinFormsApplicationBuilderTests"— 31 passed, 0 failed.dotnet build docs\application-builder\benchmarks\WinFormsApplicationBuilder.Benchmarks.csproj --configuration Release --no-restore --verbosity minimal— passed, 0 warnings and 0 errors.dotnet run --configuration Release --project docs\application-builder\benchmarks\WinFormsApplicationBuilder.Benchmarks.csproj— completed successfully for all three scenarios. Measurements are diagnostic, not CI thresholds.Manual sample runs completed successfully for C# and Visual Basic, using both the default startup form and
--custom-context.git diff --check— passed.Full solution build and full unit-test suite were not run locally; CI checks are pending.
Accessibility testing
N/A — no visible UI or controls are added or changed.
Test environment(s)
Microsoft Reviewers: Open in CodeFlow