Conversation
# Conflicts: # src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.cs # src/BootstrapBlazor/Options/DateTimeSettings.cs # test/UnitTest/Components/DateTimePickerTest.cs
Reviewer's GuideRenames the DateTimePicker parsing delegates from *Resolve to *Callback across component, options, samples, and tests, while making DateTimeHelper public with improved XML docs and simplifying its unit tests to call it directly, plus adding documentation and localization entries for new DateTimeSettings options and editable parsing demo. Sequence diagram for DateTimePicker parsing with ParseDateTimeCallbacksequenceDiagram
actor User
participant DateTimePicker
participant DateTimeSettings
participant DateTimeHelper
User->>DateTimePicker: input value
DateTimePicker->>DateTimeSettings: Options.CurrentValue.DateTimeSettings
DateTimePicker->>DateTimePicker: ParseDateTimeCallback
alt [ParseDateTimeCallback != null]
DateTimePicker->>DateTimePicker: ParseDateTimeCallback(value)
else [ParseDateTimeCallback == null]
DateTimePicker->>DateTimeSettings: ParseDateTimeCallback
alt [DateTimeSettings.ParseDateTimeCallback != null]
DateTimePicker->>DateTimeSettings: ParseDateTimeCallback(value)
else [no callbacks]
DateTimePicker->>DateTimeHelper: ToDateTime(value)
end
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Renaming the public
ParseDateTimeResolve/ParseDateTimeOffsetResolveAPIs toParseDateTimeCallback/ParseDateTimeOffsetCallbackis a breaking change; consider keeping the old properties as[Obsolete]shims that delegate to the new ones to avoid breaking existing consumers. - The removal of compact formats
"yyyy-M-d"and"yyyy/M/d"fromDateTimeHelperchanges previously accepted input formats; if this is not intentional, restore these patterns or document clearly why they are no longer supported.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Renaming the public `ParseDateTimeResolve`/`ParseDateTimeOffsetResolve` APIs to `ParseDateTimeCallback`/`ParseDateTimeOffsetCallback` is a breaking change; consider keeping the old properties as `[Obsolete]` shims that delegate to the new ones to avoid breaking existing consumers.
- The removal of compact formats `"yyyy-M-d"` and `"yyyy/M/d"` from `DateTimeHelper` changes previously accepted input formats; if this is not intentional, restore these patterns or document clearly why they are no longer supported.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 771 771
Lines 34537 34535 -2
=========================================
- Hits 34537 34535 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Link issues
fixes #8303
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Rename DateTime parsing customization hooks to use Callback naming, make DateTimeHelper public with improved XML documentation, and update related usage, documentation, and tests.
New Features:
Enhancements:
Tests: