补充 build/run 调用契约测试#103
Merged
Merged
Conversation
Contributor
Author
|
@ZR233 hi，请问可以 review 一下吗 |
ZR233
reviewed
May 15, 2026
| fn qemu_byte_stream_success_matches_before_newline() -> Result<()> { | ||
| let Some(outcome) = run_case( | ||
| &[r"Hit any key to stop autoboot:"], | ||
| &[r"Scanning bootdev 'fw-cfg@9020000\.bootdev':"], |
Contributor
Author
There was a problem hiding this comment.
这个最开始是因为 qemu 用了 nowait，如果连接晚了会错过这一条，现在改成了主动触发
ZR233
reviewed
May 15, 2026
|
|
||
| /// Verifies board run parsing accepts Cargo package and bin selectors. | ||
| #[test] | ||
| fn parse_board_run_with_cargo_selector_args() { |
| #[tokio::test] | ||
| /// Verifies Cargo artifact state is recorded without forced BIN conversion. | ||
| async fn handle_output_writes_cargo_artifact_state_without_runtime_conversion() { | ||
| let temp = tempfile::tempdir().unwrap(); |
MRNIU
force-pushed
the
feature/build-run-contract-tests
branch
3 times, most recently
from
0131662 to
ae214f6
Compare
补齐 build/run 路径上的测试护栏，并根据 review 收敛测试边界。 - 使用显式 virtio-net QEMU fixture 稳定 byte-stream 集成测试，避免默认 NIC ROM 依赖导致串口不可用。 - 使用测试主动输出的 U-Boot marker 验证真实 TCP serial 字节流匹配，避免依赖 arch、FDT 或 bootflow 日志。 - 用 apply_cargo_selector 行为测试替换低价值 clap 字段映射断言。 - 澄清 CargoBuilder 测试覆盖 resolved artifact 写入 runtime state，而非 serde 配置解析。
MRNIU
force-pushed
the
feature/build-run-contract-tests
branch
from
ae214f6 to
8fd71e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
Review 对齐
apply_cargo_selector对 build config/runtime state 的实际影响。验证