Skip to content

Fix SSH fleet with proxy_jump in-place update check #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
un-def merged 1 commit into from
Feb 26, 2026
Merged

Fix SSH fleet with proxy_jump in-place update check #3612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/dstack/_internal/server/services/fleets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,10 +1074,18 @@ def _calculate_ssh_hosts_changes(
if isinstance(current_host, str) or isinstance(new_host, str):
if current_host != new_host:
changed_hosts.add(host)
elif diff_models(
current_host, new_host, reset={"identity_file": True, "proxy_jump": {"identity_file"}}
):
changed_hosts.add(host)
else:
current_host = copy_model(current_host, reset={"identity_file"})
new_host = copy_model(new_host, reset={"identity_file"})
# XXX: cannot use copy_model() or diff_models() with
# `reset={..., "proxy_jump": {"identity_file"}}`
# as SSHProxyParams.identity_file has no default value
if current_host.proxy_jump is not None:
current_host.proxy_jump.identity_file = ""
if new_host.proxy_jump is not None:
new_host.proxy_jump.identity_file = ""
if diff_models(current_host, new_host):
changed_hosts.add(host)
return added_hosts, removed_hosts, changed_hosts


Expand Down