Skip to content

Fix firefox new tab perm #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewsong18 wants to merge 2 commits into
base: ExperimentalTabMode
Choose a base branch
from
Open

Fix firefox new tab perm #3118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ebd5d
fix: propagate Chrome script injection errors
matthewsong18 Nov 5, 2026
5c5f3c3
fix: skip injection when the tab URL is unavailable
matthewsong18 Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions plugin/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,25 +241,29 @@ var main = (function() {
}
}

function injectContentScript(tabId) {
async function injectContentScript(tabId) {
// Checking for firefox here because `browser.*` requires minimum chrome version 148
const tab = util.isFirefox()
? await browser.tabs.get(tabId)
: await chrome.tabs.get(tabId);

const cannotReadUrl = !tab.url;
if (cannotReadUrl) {
return;
}

if (util.isFirefox()) {
return Firefox.injectContentScript(tabId);
} else {
chromeInjectContentScript(tabId);
return chromeInjectContentScript(tabId);
}
}

function chromeInjectContentScript(tabId) {
try {
chrome.scripting.executeScript({
target: {tabId: tabId},
files: ["js/ContentScript.js"]
});
} catch {
if (chrome.runtime.lastError) {
util.log(chrome.runtime.lastError.message);
}
}
return chrome.scripting.executeScript({
target: {tabId: tabId},
files: ["js/ContentScript.js"],
});
}

function populateControls() {
Expand Down
Loading