Make NumberNode mutate methods return void
#469
Merged
+129
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastbodin
force-pushed
the
bug/narrow_contracts_for_numbernode_mutate_methods
branch
2 times, most recently
from
858626a to
150dfd8
Compare
As opposed to `bool`. Changed methods include: `NumberNode::exchange()`, `NumberNode::clip_and_set_value()`, `IntegerNode::set_value()`, `BinaryNode::flip()`, `BinaryNode::set()`, and `BinaryNode::unset()`. C++ tests updated to reflect these changes.
fastbodin
force-pushed
the
bug/narrow_contracts_for_numbernode_mutate_methods
branch
from
150dfd8 to
866f57e
Compare
arcondello
approved these changes
Jan 23, 2026
alexzucca90
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to
bool. Changed methods include:NumberNode::exchange(),NumberNode::clip_and_set_value(),IntegerNode::set_value(),BinaryNode::flip(),BinaryNode::set(), andBinaryNode::unset(). C++ tests updated to reflect these changes.