Open
Conversation
seventil
added
[scope] maintenance
Member
AndrewSazonov
left a comment
AndrewSazonov
left a comment
There was a problem hiding this comment.
Could you please attach screenshots of the table showing the selection in both light and dark themes?
Author
added to the PR description |
AndrewSazonov
approved these changes
Mar 23, 2026
Member
AndrewSazonov
left a comment
AndrewSazonov
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use selectModels with TableViews there is a need form appropriate selection colors.
Current Theme Accent colors are too saturated to be used as selection (IMO), so I introduce a Minor Theme Accent to use instead.
Examples of selection and a hover in light and dark themed tableview are attached. Note that active selection is on the second row and hover is on the fourth row.
