Skip to content

Add single-crystal diffraction support via cryspy#127

Merged
AndrewSazonov merged 79 commits intodevelopfrom
25-implement-single-crystal-diffraction-support-via-cryspy-to-validate-design-for-multiple-sample_form-experiment-types
Mar 14, 2026
Merged

Add single-crystal diffraction support via cryspy#127
AndrewSazonov merged 79 commits intodevelopfrom
25-implement-single-crystal-diffraction-support-via-cryspy-to-validate-design-for-multiple-sample_form-experiment-types

Conversation

@AndrewSazonov
Copy link
Member

This PR implements single-crystal diffraction support via cryspy.

…upport-via-cryspy-to-validate-design-for-multiple-sample_form-experiment-types
@AndrewSazonov AndrewSazonov merged commit 6a52ea9 into develop Mar 14, 2026
34 of 36 checks passed
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 90.50132% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.28%. Comparing base (883c384) to head (3e738b2).
⚠️ Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
src/easydiffraction/display/plotting.py 71.11% 20 Missing and 6 partials ⚠️
src/easydiffraction/analysis/calculators/cryspy.py 90.58% 5 Missing and 11 partials ⚠️
...easydiffraction/experiments/experiment/bragg_sc.py 75.00% 10 Missing and 2 partials ⚠️
...iffraction/experiments/categories/data/bragg_sc.py 96.06% 4 Missing and 1 partial ⚠️
src/easydiffraction/display/plotters/ascii.py 88.23% 1 Missing and 3 partials ⚠️
src/easydiffraction/display/plotters/plotly.py 94.59% 1 Missing and 1 partial ⚠️
...ction/experiments/categories/instrument/factory.py 83.33% 1 Missing and 1 partial ⚠️
src/easydiffraction/display/plotters/base.py 93.33% 1 Missing ⚠️
...ion/experiments/categories/background/chebyshev.py 50.00% 1 Missing ⚠️
...iffraction/experiments/categories/data/bragg_pd.py 98.11% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #127      +/-   ##
===========================================
+ Coverage    82.26%   84.28%   +2.02%     
===========================================
  Files           88       91       +3     
  Lines         5451     5911     +460     
  Branches       454      496      +42     
===========================================
+ Hits          4484     4982     +498     
+ Misses         802      746      -56     
- Partials       165      183      +18     
Flag Coverage Δ
integration 70.12% <74.93%> (+0.17%) ⬆️
unittests 71.78% <51.45%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement single-crystal diffraction support (via Cryspy) to validate design for multiple sample_form experiment types

1 participant