Skip to content

WIP: remove ToAnyParam and use Into<Param> instead#314

Draft
divarvel wants to merge 2 commits into
mainfrom
push-tyuolupwolsq
Draft

WIP: remove ToAnyParam and use Into<Param> instead#314
divarvel wants to merge 2 commits into
mainfrom
push-tyuolupwolsq

Conversation

@divarvel

@divarvel divarvel commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Continuation of #302

The goal is to:

  • remove the possibility of passing a public key where a term is expected
  • remove ToAnyParam in favor of Into<AnyParam> for simplicity
  • (possibly) extend the passing of public keys to support multiple keys at once, and keywords.

The main difference is that ToAnyParam takes a reference, while Into consumes its input.

todo

  • try using Into<Term> instead of T: ToAnyParam
  • try using Into<(PublicKey, Vec<PublicKey>)> instead of PublicKey

@divarvel
divarvel force-pushed the push-tyuolupwolsq branch 2 times, most recently from bfe8fa6 to d23e011 Compare September 16, 2025 09:38
@divarvel divarvel mentioned this pull request Sep 16, 2025
Merged
6 tasks
@divarvel
divarvel marked this pull request as draft September 16, 2025 09:55
@divarvel
fix parameter confusion in macros
eef53bb 
macros resolve scope parameters and regular parameters through the `ToAnyParams` trait, losing the ability to discriminate between the two in a static way. This leads to panics instead of compilation errors.
@divarvel
replace ToAnyParam with Into<Term> in macro calls
b99af0b 
This removes the possibility to provide a public key where a term is expected and leverages a standard trait instead of a custom one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Geal Geal Geal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divarvel @Geal