Skip to content

Key-binding does not show in menu if the key-binding specifies parameter for the command #453

Description

@anishthecoder

Let's say I have a command to exit-application. Assume this command takes an optional parameter request-confirmation. In the appropriate key-binding context, key-binding M1+Q is defined to trigger the this command. If no parameter value for request-confirmation is specified with this binding, the shortcut (Ctrl+Q) appears in the menu where there is a menu item triggering this same command.

However, if a parameter value is added to the same key-binding, the shortcut no longer appears. The actual key-binding still works and the command is executed correctly with the appropriate parameter value when using the key-binding.

The problem appears to be in

When the menu item is being rendered, this line does not find the key-binding for the command.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions