Restrict file transfer URL scheme to http(s) - #392
Merged
Merged
Conversation
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
y1yang0
approved these changes
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens file-transfer-by-URL handling to only allow http/https URLs, reducing exposure to local resource disclosure via non-HTTP URL schemes.
Changes:
- Add DTO-level validation to require an
http(s)URL scheme forFileTransferMethod.URL. - Add service-level runtime enforcement to reject non-
http(s)protocols before opening a connection. - Expand tests to cover rejection of
file:,jar:,ftp:and acceptance ofhttp(s)URLs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/src/main/java/org/eclipse/jifa/server/domain/dto/FileTransferRequest.java | Replaces URL “not blank” validation with an http(s) scheme check. |
| server/src/main/java/org/eclipse/jifa/server/service/impl/StorageServiceImpl.java | Enforces http(s) protocol before opening URL connections. |
| server/src/test/java/org/eclipse/jifa/server/domain/dto/TestFileTransferRequest.java | Adds coverage for rejecting non-http(s) schemes and accepting http(s). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Denghui Dong <denghui.ddh@alibaba-inc.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.