chore: upgrade to react-router 7 - #1997
Merged
netomi merged 2 commits intoJul 27, 2026
Merged
Conversation
gnugomez
force-pushed
the
gnugomez/main/upgrade-react-router
branch
from
July 27, 2026 08:35
76e6136 to
97e6128
Compare
Replace react-router-dom with react-router; v7 folds the DOM exports into the main package. Also drops the stale @types/react-router-dom v5 typings. Stops at 7.18.1 rather than v8: v8 requires react/react-dom 19.2.7+ and this app is on React 18. Node 22.22 already meets v8's floor, so React is the only blocker - deferred until there is enough test coverage to make a React major safe. No future flags were needed: the data-router flags don't apply to <BrowserRouter>, all links under the /admin-dashboard/* splat are absolute, and every React.lazy call is at module scope. Breaking for consumers passing additionalRoutes - they must move to react-router 7 too. Assisted-By: anthropic:claude-opus-4-8[1m]
gnugomez
force-pushed
the
gnugomez/main/upgrade-react-router
branch
from
July 27, 2026 09:14
97e6128 to
6bddf3d
Compare
gnugomez
marked this pull request as ready for review
July 27, 2026 09:15
netomi
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace react-router-dom with react-router; v7 folds the DOM exports into the main package. Also drops the stale @types/react-router-dom v5 typings.
Stops at 7.18.1 rather than v8: v8 requires react/react-dom 19.2.7+ and this app is on React 18. Node 22.22 already meets v8's floor, so React is the only blocker - deferred until there is enough test coverage to make a React major safe.
No future flags were needed: the data-router flags don't apply to , all links under the /admin-dashboard/* splat are absolute, and every React.lazy call is at module scope.
Breaking for consumers passing additionalRoutes - they must move to react-router 7 too.