Conversation
Refactor out common base class and _start_broker. Add _reboot_broker. Test QoS 0 Update test_mqttv5.py Update test_mqttv5.py Replace Exception with warning Add _TestBrokerRebootsQoS1 and _TestBrokerRebootsQoS2 They do fail, but do not get stuck in the reconnection loop as described in issue eclipse-paho#893 Create ex.py Update test_mqttv5.py Update test_mqttv5.py Remove xfails & _TestBrokerRebootsQoS1 and _TestBrokerRebootsQoS2 Import MQTTErrorCode Deactivate _TestBrokerRebootsQoS2. Ignore Python 3.9 & 3.10 for now Aquire locks for switcheroo, and test it worked on the out messages queue Xfail the QoS 2 topic alii & rebooted broker test Move test setup logic into overridden setUpClass so xfail is more targeted. Test QoS 2 topic alii, broker reboots. Explain why not to add a similar naive QoS 2 test class Rename classes
Add Client.drop_out_messages and add test for work around using it
pswsm
approved these changes
Sep 3, 2026
PierreF
reviewed
Sep 9, 2026
| max-parallel: 4 | ||
| matrix: | ||
| python: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| python: ["3.11", "3.12", "3.13", "3.14" ] #, "3.9", "3.10", ] |
Contributor
There was a problem hiding this comment.
Why removing Python 3.9 & 3.10 here ? Tests works on 3.9 on main and on this PR.
Contributor
Author
There was a problem hiding this comment.
Hi Pierre,
This was from back in July. I don't remember exactly why, unfortunately. Lets try it with 3.9 & 3.10 back in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #893
Includes PR #937 and builds on its new tests.
Completes #935