Repository navigation
Fix MQTTMatcher # wildcard not matching parent level - #953
Closed
sankalpsthakur wants to merge 1 commit into
Closed
sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
MQTT spec 4.7.1.2 requires that a multi-level wildcard includes the parent level, so a filter of "sport/#" matches the topic "sport". Apply the '#' match in the terminal branch of iter_match and add a unit test covering that parent-level case. Fixes eclipse-paho#950 Signed-off-by: Sankalp <sankalphimself@gmail.com> Co-authored-by: Sankalp Thakur <sankalpsthakur@users.noreply.github.com>
Contributor
|
The author has not run the tests in our workflows. |
JamesParrott
suggested changes
Sep 1, 2026
JamesParrott
left a comment
JamesParrott
left a comment
Contributor
There was a problem hiding this comment.
Please close this PR. Or at least run the project's tests in your own workflows, and adjust them to show what exactly the issue is. I have done so, and as far as I can tell, the original issue is a nothing burger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #950