Skip to content

Adding datarouter reqs checklist - #335

Open
MaciejKaszynski wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:datarouter-comp-req-chklist
Open

MaciejKaszynski wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:datarouter-comp-req-chklist

Conversation

@MaciejKaszynski

@MaciejKaszynski MaciejKaszynski commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Notes for Reviewer

Adding datarouter reqs checklist

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #326

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 587ee9bf-87e0-421f-aa9b-6bff05dd36ff
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.17, but got rules_cc@0.2.25 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
DEBUG: /home/runner/.bazel/external/score_docs_as_code+/docs.bzl:716:14: INFO: ⚠️ DEPRECATED: Passing a Needs inventory through docs(data = [...]) is deprecated!!! Move it to external_needs = [...] instead.
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 16.450s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@MaciejKaszynski
MaciejKaszynski force-pushed the datarouter-comp-req-chklist branch from 9f5304d to 3492ea7 Compare September 29, 2026 07:55
@MaciejKaszynski
MaciejKaszynski force-pushed the datarouter-comp-req-chklist branch from f28c72f to a77ee67 Compare October 6, 2026 06:34
@MaciejKaszynski
MaciejKaszynski force-pushed the datarouter-comp-req-chklist branch from a77ee67 to 89529fb Compare October 6, 2026 06:34
@MaciejKaszynski
MaciejKaszynski marked this pull request as ready for review October 6, 2026 06:34
:id: doc__datarouter_req_inspection
:status: draft
:version: 1
:safety: ASIL_B

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:safety: ASIL_B
:safety: ASIL_QM

Datarouter is not safety relevant /ASIL B/
Please confirm if we really need an inspection checklist for it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this now, the checklist is still needed for QM, but safety related items don't need to be filled.

@rmaddikery rmaddikery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments need to be addressed

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — f5eb2267 Waiting Oct 27, 2026 by MaciejKaszynski via run-tests / coverage approval gate #1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

[comp datarouter] Component Requirements check/adapt

2 participants