Skip to content

Fix #366 Missleading/Outdated comment in data router - #368

Merged
rmaddikery merged 1 commit into
eclipse-score:mainfrom
uwe-martin:fix/outdated_comment_data_router
Oct 22, 2026
Merged

rmaddikery merged 1 commit into
eclipse-score:mainfrom
uwe-martin:fix/outdated_comment_data_router

Conversation

@uwe-martin

@uwe-martin uwe-martin commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Related Issue

Resolves #366

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #366

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: d190166a-ddea-47a7-ae8c-9ce9c2dc7cc8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
DEBUG: /home/runner/.bazel/external/score_docs_as_code+/docs.bzl:716:14: INFO: ⚠️ DEPRECATED: Passing a Needs inventory through docs(data = [...]) is deprecated!!! Move it to external_needs = [...] instead.
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 15.907s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-project-automation github-project-automation Bot moved this from Backlog to On Hold in LOG - Logging FT Oct 22, 2026
@rmaddikery
rmaddikery merged commit 359df78 into eclipse-score:main Oct 22, 2026
13 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from On Hold to Done in LOG - Logging FT Oct 22, 2026

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — 0d48be59 Waiting Oct 22, 2026 by rmaddikery via approval #911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Missleading/Outdated comment in data router

2 participants