Repository navigation
Conversation
The remainder after each case used !fn(data), so a case that returned 0, '', false or null fired and the payload still went on to later cases and __. Only undefined means no match now, same as filterMap. Fixes effector#356
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #356.
splitMapbuilds the remainder after each case withcurrent.filter({ fn: (data) => !fn(data) }), while the case event itself usesfilterMap(fn), which only skipsundefined. So when a case returns0,'',falseornull, the case event fires and the payload still goes on to later cases and__:The docs say cases are tried "until function returns non undefined" and
__fires when "each other function returnsundefined", so the remainder filter is nowfn(data) === undefined.Added a test in
split-map.test.tswith0,'',falseandnullresults; it fails onmainand passes with the fix.jest: 60 suites, 423 tests pass.