Bump cl-unicode past edicl#22 IDNA → OCI 0.1.7 - #23
Merged
Conversation
Tag v0.1.6 (2019) predates the merged IDNA mappings PR (edicl/cl-unicode#22). OCI 0.1.6 therefore lacks idna-mapping and breaks cl-idna (cl-stack#164). Pin edicl master @ 07e7ff5 and force OCI tag 0.1.7 (asd still says 0.1.6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cl-unicode:0.1.6was published from tag v0.1.6 (2019-04), which predates merged IDNA PR edicl/cl-unicode#22. OCI therefore lacksidna-mapping→ breaks cl-idna (cl-stack#164).Change
edicl/cl-unicode@07e7ff5(master post-docs: mark esrap + trivial-utf-8 published #22)imports/cl-unicode/versionNot using
egao1980/cl-unicodefor this: fork is only ahead with open edicl#34. IDNA is already on edicl master.After merge
Test plan
cl-unicodesucceedscl-unicode:idna-mappingcl-idnaloads against OCI 0.1.7