Normalize Windows drive-letter localfile URLs before resolving file p…#1654
Open
Douglasymlai wants to merge 1 commit into
Open
Normalize Windows drive-letter localfile URLs before resolving file p…#1654Douglasymlai wants to merge 1 commit into
Douglasymlai wants to merge 1 commit into
Conversation
…aths and improve local HTML asset inlining for rendered project content.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** Remove script blocks so img tag scans match real HTML, not JS template strings. */ | ||
| export function stripScriptBlocks(html: string): string { | ||
| return html.replace(/<script[\s\S]*?<\/script>/gi, ''); |
|
|
||
| /** Remove script blocks so img tag scans match real HTML, not JS template strings. */ | ||
| export function stripScriptBlocks(html: string): string { | ||
| return html.replace(/<script[\s\S]*?<\/script>/gi, ''); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #TODO
Description
This PR fixes local HTML asset rendering issues in project content, especially when assets are loaded through
localfile://URLs on Windows.It normalizes Windows drive-letter
localfilepaths in the Electron protocol handler, extracts local HTML asset rewriting into shared helpers, inlines both<img>elements and quoted local project image paths, and avoids incorrectly rewriting JavaScript template-literal placeholders such as${...}. It also injects a local base href so relative asset references resolve more reliably.Testing Evidence (REQUIRED)
Automated:
npx vitest run test/unit/electron/main/index.test.ts test/unit/lib/htmlLocalAssets.test.ts test/unit/lib/htmlSanitization.test.ts3test files passed,98tests passedManual:
I have included human-verified testing evidence in this PR.
This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
No frontend/UI changes in this PR.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement