fix(factory): route stderr writes through configureOutput - #502
Open
margaretjgu wants to merge 2 commits into
Open
fix(factory): route stderr writes through configureOutput#502margaretjgu wants to merge 2 commits into
margaretjgu wants to merge 2 commits into
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts MegaLinter is graciously provided by OX Security |
JoshMock
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #455.
Migrates the error-path writes in
factory.ts's action handler fromprocess.stderr.writetocmd.configureOutput().writeErr, the channelcmd.error()and existing tests already use. Left stdout writes alone:configureHelpWithSchemaalready claimswriteOuton every command for--helpoutput, so routing regular handler output through it would silently change write semantics. Confirmed by migrating it first and watchingstatus/sanitize/scroll-searchtests break, then reverting that part.Also bumps
fast-uri3.1.4 to 3.1.5 to clear a Trivy-flagged CVE that was failing CI, unrelated to the factory.ts change.