[AWS CIS] Change logging non blocking errors to warning#3862
Closed
[AWS CIS] Change logging non blocking errors to warning#3862
Conversation
|
This pull request does not have a backport label. Could you fix it @romulets? 🙏
|
orouz
approved these changes
Jan 19, 2026
amirbenun
reviewed
Jan 19, 2026
Contributor
amirbenun
left a comment
There was a problem hiding this comment.
Let's have more clarity on the errors that are returned from AWS SDK.
dbe86ab to
f4fdd05
Compare
f4fdd05 to
7f48e4c
Compare
amirbenun
reviewed
Jan 19, 2026
| return | ||
| } | ||
| errMsg := err.Error() | ||
| if strings.Contains(errMsg, "NoSuchBucket") { |
Contributor
There was a problem hiding this comment.
Instead of strings comparison
var nsb *types.NoSuchBucket
if errors.As(err, &nsb) {
p.log.Warnf("Error getting bucket %s for bucket %s: %v", operation, bucketName, err)
return
}
kubasobon
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changed log lines are over alerting right now, it should be a warn instead of error