-
Notifications
You must be signed in to change notification settings - Fork 34
Applies_to: Expand versioning features #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cotti
wants to merge
75
commits into
main
Choose a base branch
from
feat/versionspec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,902
−951
Open
Changes from 7 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
9abe711
Introduce VersionSpec, a model meant for advanced version handling fo…
cotti 73e8dd7
Apply usage of VersionSpec in Applicability
cotti e6d710f
Show base version if we don't get a specified version for a versioned…
cotti 4bd996a
Adjust tests to better match the currently expected output
cotti 7ead716
Add VersionSpec to YamlSerialization
cotti fcae628
Typo!
cotti e435de9
No need for it to be initialized here after all.
cotti 7f5f2be
Handle "all" explicitly
cotti 00ab8d0
Adopting a few review suggestions
cotti 2613a13
Fix warnings on docs-builder docs
cotti d4cce98
Include applicability table in req.md
cotti 043c470
Fix markdown formatting
cotti 11580bd
Products with versions should show their base versions in badges with…
cotti 56af075
Introduce implicit semantics for multiple lifecycles
cotti 7d0f792
Add more examples in docs
cotti 13301d0
Typo
cotti 7cd899b
Fix interpretation of lifecycle - using ranges after current stack ve…
cotti 072479e
Change popup to a popover component, alongside static descriptions
cotti 8db2669
Preview: send a limited assembler build to the preview environment
cotti d953e71
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti 817cfc6
Fix Call to the Renderer
cotti 0f2ce56
Remove unused var
cotti 917d18b
typo
cotti 6a1fde8
Invalidate correct subfolder
cotti 0458208
Fix policy path
cotti cd331f0
Fix policy
cotti d728b6a
Send path-prefix to assembler.
cotti b799f69
Revert temporary assembler build for now
cotti a013f99
Fix admonition tests
cotti 2675baf
Transfer applicablity popover data properly as JSON
cotti f39f3d5
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti 004ed8e
Avoid duplicate warnings
cotti e574153
Adjust existing tests
cotti 171ef22
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti f824af8
Fix lint
cotti cb4b386
Introduce more test scenarios
cotti 9e2875e
Adjust cursor behavior on desktop
cotti 38d912b
Only use 'since' when a version is set
cotti ea8776f
Fix presentation of applicability details
cotti 6852739
Readjust applicability ordering
cotti 1899559
Adjust version display when no lifecycles are stated
cotti 501fb5e
Handle multiple future versions
cotti 2359938
Fix test and ranges between versions
cotti 3af43c4
Typo
cotti 4f7f107
Remove unused value
cotti 8bf4658
Allow special rule for ranges
cotti ebca4ff
Allow version bump overlaps
cotti 0be4340
Adjust availability list item display
cotti 4c7bd53
Adjust tests
cotti 40a3e59
Remove duplicate information
cotti 5906947
Fix badge display ordering
cotti ae1186a
Temporary downgrade the severity of new warnings
cotti 5ed1ed4
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti f4cd2de
Remove a few instantiations in favor of static definitions
cotti a7a55e4
Remove code duplications
cotti 86fce10
Fix tests
cotti 2724eb7
Fix range rendering when the difference is at the patch level
cotti c4b6fd4
Show range-level versions on applicability items
cotti 0cf82bb
Update src/Elastic.Documentation.Site/Assets/web-components/AppliesTo…
cotti a7f0364
Update src/Elastic.Markdown/Myst/Components/ProductDescriptions.cs
cotti da72ba0
Fix tests
cotti 7d8546c
lint fix
cotti e293bd6
Revert showing patch-level versions in applicability headers
cotti 34e97a6
Add applicability ruleset tables to the docs
cotti d45bcf9
Remove redundant snippet
cotti c6fb94a
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti 788e680
Merge branch 'main' into feat/versionspec
cotti b1d1ddc
Include explicit ! operator to display patch versions.
cotti 64eea66
Match EUI tooltip default delay
cotti 56583cb
Merge branch 'main' into feat/versionspec
cotti 05d1fe8
Adjust unavailable lifecycle description and add a link to the releas…
cotti 9ddfbdd
Merge remote-tracking branch 'origin/main' into feat/versionspec
cotti 7e35036
Fix remaining test
cotti b637f9e
Fix rendering
cotti e0f6c1e
Adjust version syntax demonstration
cotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| `applies_to` accepts the following version formats: | ||
|
|
||
| * `Major.Minor` | ||
| * `Major.Minor.Patch` | ||
| * **Greater than or equal to**: `x.x+`, `x.x`, `x.x.x+`, `x.x.x` (default behavior when no operator specified) | ||
| * **Range (inclusive)**: `x.x-y.y`, `x.x.x-y.y.y`, `x.x-y.y.y`, `x.x.x-y.y` | ||
| * **Exact version**: `=x.x`, `=x.x.x` | ||
|
|
||
| Regardless of the version format used in the source file, the version number is always rendered in the `Major.Minor.Patch` format. | ||
| **Version Display:** | ||
|
|
||
| - Versions are always displayed as **Major.Minor** (e.g., `9.1`) in badges, regardless of the format used in source files. | ||
| - Each version represents the **latest patch** of that minor version (e.g., `9.1` means 9.1.0, 9.1.1, 9.1.6, etc.). | ||
| - The `+` symbol indicates "this version and later" (e.g., `9.1+` means 9.1.0 and all subsequent releases). | ||
| - Ranges show both versions (e.g., `9.0-9.2`) when both are released, or convert to `+` format if the end version is unreleased. | ||
|
|
||
| :::{note} | ||
| **Automatic Version Sorting**: When you specify multiple versions for the same product, the build system automatically sorts them in descending order (highest version first) regardless of the order you write them in the source file. For example, `stack: ga 8.18.6, ga 9.1.2, ga 8.19.2, ga 9.0.6` will be displayed as `stack: ga 9.1.2, ga 9.0.6, ga 8.19.2, ga 8.18.6`. Items without versions (like `ga` without a version or `all`) are sorted last. | ||
| **Automatic Version Sorting**: When you specify multiple versions for the same product, the build system automatically sorts them in descending order (highest version first) regardless of the order you write them in the source file. For example, `stack: ga 9.1, beta 9.0, preview 8.18` will be displayed with the highest priority lifecycle and version first. Items without versions are sorted last. | ||
| ::: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.