[Inference API] Enable ccm setting by default #139154
Draft
+41
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:SearchOrg/Inference
DonalEvans
approved these changes
Dec 9, 2025
Comment on lines
37
to
45
| private static final MockElasticInferenceServiceAuthorizationServer mockEISServer = | ||
| new MockElasticInferenceServiceAuthorizationServer(); | ||
|
|
||
| static { | ||
| // Ensure that the mock EIS server has an authorized response for each node that will be upgraded prior to the cluster starting | ||
| for (int i = 0; i < NODE_NUM; i++) { | ||
| mockEISServer.enqueueAuthorizeAllModelsResponse(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Rather than using this static block, would it be neater to add an int constructor argument to MockElasticInferenceServiceAuthorizationServer that causes enqueueAuthorizeAllModelsResponse() to be called that many times?
DonalEvans
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the feature flag guarding the CCM functionality and sets the default to
true. This is so ECE and on-prem do not need to set the anything in theirelasticsearch.ymlfile, it will be enabled by default. In ECH and serverless we will disable it explicitly.