Feat/9243 dogfood eslint plugin eui#9368
Conversation
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
|
buildkite test this |
weronikaolejniczak
left a comment
There was a problem hiding this comment.
I ran the ESLint plugin tests locally and they all passed. I ran the linter and it's reporting only warnings, and in line with what we have in our ESLint plugin. The code looks correct. Thank you for finding and addressing that critical issue in no_css_color. 🟢 Great contribution, @ragini-pandey! 🙌🏻
|
buildkite test this |
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
Thank you for the review @weronikaolejniczak! |
Summary
This PR implements issue #9243 by dogfooding the
@elastic/eslint-plugin-euiin thepackages/euipackage.Changes made:
@elastic/eslint-plugin-euias a workspace devDependency inpackages/eui/package.jsonpackages/eui/.eslintrc.jsno-css-colorrule where it would crash when encountering arrow functions that return non-object expressions (e.g.,css={() => undefined}). Added proper null/type checking before calling.filter()on properties.The plugin now successfully runs on the EUI codebase, reporting 786 warnings across various accessibility and code quality rules.
Why are we making this change?
Closes #9243
By using our own ESLint plugin in the EUI package, we can:
Screenshots
Not applicable - this is a development tooling change
Impact to users
No impact to end users. This is an internal development change that only affects contributors to the EUI repository. The ESLint plugin was already published and available to consumers; this PR simply enables it within the EUI package itself for improved code quality during development.
QA
General checklist