Repository navigation
ci: bump rustsec/audit-check to Node 24 build - #17
Closed
claude[bot] wants to merge 2 commits into
Closed
claude[bot] wants to merge 2 commits into
claude[bot] wants to merge 2 commits into
Conversation
rustsec/audit-check v2.0.0 declares `using: node20`, which now emits a "Node.js 20 is deprecated" warning in the `ci / audit` job. The only Node 24 build is the current tip of `main` (v2.0.0 plus the runtime bump in rustsec/audit-check#48), so pin to that commit until a release is cut. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016CQBJJfSsx2K4ajrfY43iX
zizmor's ref-version-mismatch audit reads "# v2.0.0" in the comment as a version claim and correctly notes the pinned SHA is not that tag. The pin is the tip of main, so describe it as such instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016CQBJJfSsx2K4ajrfY43iX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
Before: The
ci / auditjob (reached via the Release workflow'sworkflow_callintoci.yml) pinsrustsec/audit-check@69366f33…(v2.0.0), which declaresusing: node20, so every run emits "Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24".After: The job pins
rustsec/audit-check@858dc40f…, the current tip of that action'smain, which is v2.0.0 plus only thenode20tonode24runtime bump (rustsec/audit-check#48). No inputs or behaviour change; the deprecation warning goes away.How: Flagged by the electron/private-workflows Audit Deprecations run for Release run 30419305406 on
main. rustsec/audit-check has no tagged release newer than v2.0.0, so this pins the Node 24 commit onmain(SHA + comment, per repo convention). Worth re-pinning to a tag once upstream cuts one.🤖 Generated with Claude Code
https://claude.ai/code/session_016CQBJJfSsx2K4ajrfY43iX
Generated by Claude Code