Allow secondary windows to have different pane state#1738
Conversation
zeebok
left a comment
There was a problem hiding this comment.
This definitely solves the issue. When you test this, say have panes open in the primary window and hidden in the secondary, and then re-open Code, are the panes all practically minimum size? That happened for me, but if it is only me then go ahead with merging!
|
@zeebok Thanks for the review! I don't have a problem with reopening the primary window but I found an issue with the terminal pane in the second window which does not show initially even though it is "on". I guess the second window should initially follow the pane state of the primary window although it could be argued that it should start with no panes showing (i.e. just showing the chosen document) when it is the result of the "open document in new window" action. |
Fixes #1737
In order to have consistent predictable behaviour, we have to assert a distinction between the first opened (primary) window and any subsequent (secondary) windows. Only the primary window synchronises with settings with regard to the panes.
This raises the question as to whether secondary windows should be visually different to primary windows but that is left to another time.
The alternative is to treat all windows as equal in which case we would have to have independent settings for each window.