Gtk4Prep: ProjectChooserButton

[jeremypw]

• Use Controller instead of button_release_event
• Define action and target on each listboxrow instead of deprecated get_action_group/activate_action
• Do not listen to listbox remove signal - the GitManager is source of truth and we already listen to changes there. There is no way to remove rows (projects) through the UI of this widget.

This should work in Gtk4 with minimal changes for porting purposes.

There are no dead areas when clicking on the listboxrows.

[danirabbit]

Rows can be activated in other ways than just button presses, such as with the keyboard. So we really need to keep this

[jeremypw]

Are you sure? The rows are bound to an action now so it doesn't matter how they are activated, the action will fire.

[jeremypw]

I don't think itts possible for the checkboxes to get focus and change without activating the row but I'll check.

[jeremypw]

Ok, it is possible (though not obvious how) so I'll make the checkbuttons non-focusable.

[jeremypw]

I've fixed it so that it is possible to operate the chooser with the keyboard (once it has been opened) but because of a previously reported css bug (upstream) there is no visible focus on the rows. But the whole issue of keyboard accessibility needs revisiting after the port anyway.