Gtk4Prep: MainWindow use dialog.show where simple#1758
Open
jeremypw wants to merge 4 commits into
Open
Conversation
danirabbit
reviewed
Jun 28, 2026
| var uris = file_chooser.get_uris (); | ||
| file_chooser.destroy (); // Close now so it does not stay open during lengthy or failed loading | ||
| if (res == Gtk.ResponseType.ACCEPT) { | ||
| foreach (string uri in file_chooser.get_uris ()) { |
Member
There was a problem hiding this comment.
It looks like you've cached the list of URIs but then try to get them from the chooser again here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three more simple changes from #1739
Async stuff will be in final PR