Repository navigation
fix(desktop): clippy unnecessary_sort_by in trust ledger - #5
Merged
Merged
Conversation
CI's Desktop Tauri clippy step runs with -D warnings; sort newest-first with sort_by_key(Reverse(..)) instead of a reversed cmp closure. Signed-off-by: Eli <elijamesau@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #4's CI got past lint, unit tests, and the desktop build, then failed Desktop Tauri clippy (
-D warnings) on one lint in the new trust ledger:Change
recent.sort_by(|a, b| b.last_at.cmp(&a.last_at))→recent.sort_by_key(|s| std::cmp::Reverse(s.last_at)). Same ordering (newest first).Verified locally (hermit toolchain)
just desktop-tauri-check— clean (desktop crate now compiles locally with cmake from hermit)just desktop-tauri-clippy— cleancargo test --lib -- commands::trust_ledger commands::time_machine— 6/6Test plan