Repository navigation
test(desktop): scope same-persona agent count to the members panel - #7
Merged
Merged
Conversation
The fork's "Your team" sidebar roster lists every managed agent, so a
page-wide getByText("Pinky") count sees the two roster rows as well as
the members list + search hit and reads 4 instead of 2. Count inside
members-sidebar (the assertion's real subject) and assert the roster
rows explicitly so the fork behavior is documented, not hidden.
Signed-off-by: Eli <elijamesau@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop Smoke E2E shard 1 has failed on every fork CI run (PR #2, #4):
channels.spec.ts › members sidebar retains distinct same-persona managed agentsexpects a page-widegetByText("Pinky")count of 2 but gets 4.Root cause is the fork's own August feature, not a bug: the "Your team" roster in the sidebar (
sidebar-team-roster) lists every managed agent, so both same-persona agents named Pinky render there too. Upstream's assertion pre-dates the roster.Change
Pinkyinsidemembers-sidebar(the assertion's actual subject: the in-channel agent in the list + the out-of-channel one as a search hit) → still 2.sidebar-team-rostershows both → 2, so the fork behavior is documented rather than hidden.Test-only;
biome checkclean.Test plan