Split tuple_insert_static into two paths#15518
Open
lukaszsamson wants to merge 1 commit into
Open
Conversation
- bdd_map on pure positive disjunction - expand to the exact negation-free positive DNF, insert and union on negations and/or implicit :bdd_top Fixes elixir-lang#15517
Member
|
This fix is correct. This is the usual way to perform operations on tuple types in the theory (eliminate negations then do the operation on the disjunction of positives). The previous implementation was faster but incorrect, probably dated to before the elimination of negation was implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15517
Assisted-by: Claude Opus 4.8 & GPT 5.5