updates to your LSH - #1
Open
kecaps wants to merge 16 commits into
Open
Conversation
…en document simularity
Author
|
The MIT license you included is fine with me. |
added 4 commits
February 17, 2015 16:25
Change-Id: I076f405ac2a0c15c167bbb8659b4a6d87edd675f
Change-Id: I3e3df04928f459b8d1464edd8b6b2a02561d123e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found your implementation of LSH and started using it. As I fixed a few bugs, I started refactoring and adding some additional features (such as pluggable minhash algorithms, a multiply hash algorithm alongside xor algorithm).
I created some tests as well, and finally a small utility to see how the implementation of lsh compares to theoretical expectations.
There have been some big changes, so I'm not sure you'll want to roll them in, but since I found your code useful as a jumping off point, wanted to let you evaluate if you like the changes.
Thanks