Skip to content

Allow STRICT_JS in MODULARIZE mode. NFC#26424

Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100:strict_js_modularize
Mar 11, 2026
Merged

Allow STRICT_JS in MODULARIZE mode. NFC#26424
sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100:strict_js_modularize

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 10, 2026

Its still not allowed in EXPORT_ES6 mode where its the default.

Split out from #26421

Its still not allowed in `EXPORT_ES6` mode where its the default.

Split out from emscripten-core#26421
@sbc100 sbc100 changed the title Allow STRICT_JS in -sMODULARIZE mode. NFC Allow STRICT_JS in MODULARIZE mode. NFC Mar 10, 2026
@sbc100 sbc100 requested a review from dschuff March 10, 2026 20:39
@sbc100 sbc100 enabled auto-merge (squash) March 10, 2026 20:39
@sbc100 sbc100 requested a review from kripken March 10, 2026 21:48
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % existing suggestion

Co-authored-by: Alon Zakai <alonzakai@gmail.com>
@sbc100 sbc100 disabled auto-merge March 11, 2026 00:28
@sbc100 sbc100 merged commit d6cfd73 into emscripten-core:main Mar 11, 2026
3 of 17 checks passed
@sbc100 sbc100 deleted the strict_js_modularize branch March 11, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants